[LLVMdev] Usability of phabricator review threads for non-phab-users

[Yaron Keren]

Hi,

I have found Phabricator a better organized way to review patches than the
e-mail lists. e-mail threads are sometimes split  so you have to search for
the previous thread. e-mail threads do not show as nice as Phab shows, with
all the diffs ready and highlighted (I have a diff viewer of course but
that's an extra step). It's not always easy to find the latest patch
version in long threads.

The main problems with the current setup are
1) Phab does not enforce posting on the list (this was already discussed on
the list).
2) The coordination issues Tobias listed, most important that e-mail
replies to the Phab thread (on the list) that do not appear in Phab. It
means that once a review was started on Phab no one should reply on the
list else his reply would not show in Phab. I try to manually copy such
replies and paste to Phab comments but that's not a solution.

Yaron






2014-07-01 14:33 GMT+03:00 Tobias Grosser <tobias at grosser.es>:

> On 01/07/2014 13:11, Manuel Klimek wrote:
>
>> Alp noted that the current setup on how phab reviews land on the list are
>> not working for him. I'd be curious whether his setup is special, or
>> whether there are more widespread problems. If this is more widely
>> perceived as a problem, please speak up, and I'll make sure to prioritize
>> the fixes (note that this is unrelated to the "lost email" problem - those
>> are always highest priority and as far as I'm aware we diagnosed and fixed
>> all of them within 1-2 business days).
>>
>> If you have the feeling that the phab email workflow makes it hard for you
>> to jump into reviews, keep track of reviews, or understand reviews if
>> you're not a phab user, please reply to this thread. You don't need to
>> provide details, "+1", "please fix", or "doesn't work well for me" are all
>> acceptable replies here - I want to get a feeling for the magnitude of the
>> problem.
>>
>
> Hi Manuel,
>
> thanks for looking into this.
>
> I remember me having issues due to patch comments missing relevant context
> when looking at them on the mailing list. I think this has been both too
> little code lines, but possibly also previous comments which have not been
> cited. When people use email, they normally ensure that
> the relevant code/comments are properly cited. Phabricator does not need
> this in the web interface, which makes the emails sometimes less useful.
>
> However, I must say I don't have much experience with it and keep avoiding
> it, mostly because it does not work offline, I can not use 'vi' to
> search/work through the patches, and I need to go to a web-interface to
> submit patches instead of doing this from the command line (maybe there
> exists a script already). To get these to worlds closer, it would be
> amazing if we could have phabricator to automatically open new review
> threads if patches appear on the mailing list, to integrate comments sent
> on the mailing list and to close issues if it detects a 'committed in'. I
> know this is a lot of work, but I still wanted to mention this as features
> that would make me use phabricator more. (Most likely still sending emails,
> but using it to get
> an overview about open reviews or general review status)
>
> Cheers,
> Tobias
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140701/77e75d31/attachment.html>