[LLVMdev] [cfe-dev] Sanitizers libs in Compiler-RT

[Alexey Samsonov]

On Fri, Jan 31, 2014 at 2:30 PM, Renato Golin <renato.golin at linaro.org>wrote:

> On 31 January 2014 09:59, Alexey Samsonov <samsonov at google.com> wrote:
>
>> Huh? What tests are you talking about? I thought that tests for Clang
>> driver verifiy that the command "clang++ -fsanitize=address ...." produce a
>> correct linker invocation (with path to
>> /lib/clang/3.5/linux/libclang_rt.asan-arm.a), but don't actually require
>> the libraries to be built there. If it's not the case, we should fix that.
>>
>
> I got linker errors, since /lib/clang/3.5/linux/libclang_rt.asan-armv7l.a
> (or arm for that matter) wasn't there, since "arm" is not a recognized
> architecture.
>

What tests under tools/clang/test were failing and with what errors? I
thought that we usually test Clang with -### option, that is, only look at
the
args we're going to pass to linker, not actually invoke it.

>
> My point is that Clang sanitizer tests should *only* run IFF:
>
> 1. Compiler-rt is present AND
> 2. The architecture is recognized AND
> 3. The Asan/Lsan/UBsan etc libraries were enabled via some build option
> (individually checked).
>
> I may be wrong, but right now, it seems that they all run once compiler-rt
> is available.
>

I think that Clang tests just shouldn't depend on the presence of
compiler-rt and should always run.


>
> cheers,
> --renato
>

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140131/4fc96329/attachment.html>