[LLVMdev] making emitInlineAsm protected

[Rafael Espíndola]

On 28 January 2014 19:56, reed kotler <rkotler at mips.com> wrote:
> I would like to make the following member of AsmPrinter be protected
>
>
> void EmitInlineAsm(StringRef Str, const MDNode *LocMDNode = 0,
>                        InlineAsm::AsmDialect AsmDialect =
>                            InlineAsm::AD_ATT) const;
>
> I have some stubs that I want to emit in MipsAsmParser .

You mean Printer? There is no such a thing as inline asm in a .s file.

> Are there any objections to doing this?

Probably. EmitInilneAsm is the only case I know that has a reasonable
use of hasRawTextSupport in order for it to work on targets without an
asm parser. Exposing it exposes a way for targets avoid the MC layer.

Cheers,
Rafael