[LLVMdev] test suite 'owner'

[Robert Lytton]

Hi Eric,

Could you explain the intent and policy regarding the test-suite body of code.
Should the test be left as much as possible as-is (even if technically incorrect)?
Should changes only affect the XCore target (#ifdef) or should all targets get the changes?

Taking "int32_t main" as an example.
The correct return type & argc for main is 'int'.
In the XCore tool chain, 'int32_t' equates to long (IIRC) and hence is not acceptable in the type signature for main.
Should this change be only for the XCore target or all targets?

When I know the policy for the test-suite, I'll alter as necessary & regroup the changes into patches containing the same type of change and submit for approval.

One more question:
On patch I need to address is how to make deterministic the order of stdout & stderr.
Ideally, applications would use either stdout or stderr but not both.
Would a patch to change to only stdout be acceptable (plus any changes to expected output)?

Thank you

Robert



________________________________
From: Eric Christopher [echristo at gmail.com]
Sent: 13 January 2014 19:16
To: Robert Lytton; llvmdev at cs.uiuc.edu
Subject: [LLVMdev] test suite 'owner'

Some of these are pretty weird, e.g. int32_t main. Probably the best thing is to submit each patch individually with an explanation of what the purpose is and we can talk about them then.

-eric


On Fri Jan 10 2014 at 4:13:47 AM, Robert Lytton <robert at xmos.com<mailto:robert at xmos.com>> wrote:
Hi,

I have found it necessary to make some changes to the test-suite for the XCore platform.

These changes include:
    altering #includes, as supported by XCore;
    using stdout or stderr to make the output diffs consistent (fixing expected output too);
        (This work is still under review as best way to do it)
    'fixing' symbol and type problems e.g name clashes & scope;
    altering/adding code snippets and macros.

I have used #ifdef to limit and keep any changes specific to the XCore.
Some of these could/should be made common to all targets e.g. log2() -> logTwo().

I have also altered the Makefile to filter out tests not supported by the XCore.

I would like to discuss the changes I have found necessary to make and what is the next step.
Should any/all of them be pushed upstream?


Robert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140113/980a9142/attachment.html>