[LLVMdev] [RFC] CodeGenPrepare will eventually introduce dependencies to libLLVMCodeGen in libLLVMScalarOpts

Hal Finkel hfinkel at anl.gov
Wed Feb 19 14:11:27 PST 2014


----- Original Message -----
> From: "Chandler Carruth" <chandlerc at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "Quentin Colombet" <qcolombet at apple.com>, "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu>
> Sent: Wednesday, February 19, 2014 4:02:18 PM
> Subject: Re: [LLVMdev] [RFC] CodeGenPrepare will eventually introduce dependencies to libLLVMCodeGen in
> libLLVMScalarOpts
> 
> 
> 
> 
> 
> On Wed, Feb 19, 2014 at 1:43 PM, Hal Finkel < hfinkel at anl.gov >
> wrote:
> 
> 
> It seems to me that IR optimizations that depend directly on
> TargetLowering belong in CodeGen. Why don't you just move them all
> there?
> Some of them *could* be profitably lifted to use a more abstract
> interface like TTI. I'm pretty sure CGP is on the "not worth it"
> side of this equation, and it may not be the only thing on that
> side, but I'm trying to leave open the idea that there is some
> inflection point here and we may have passes on both sides of it
> that currently are still misusing TargetLowering and in the IR pass
> libraries.

We currently have CGP, GlobalMerge and LowerInvoke. LowerInvoke looks like it could be made to use TTI, as could GlobalMerge, because they only use a couple of methods. So I agree with you, let's just move CGP.

 -Hal

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-dev mailing list