[LLVMdev] [lld] Allow atoms with empty name in the RefNameBuilder::buildDuplicateNameMap()

Simon Atanasyan simon at atanasyan.com
Wed Feb 5 23:53:31 PST 2014


On Thu, Feb 6, 2014 at 3:06 AM, Nick Kledzik <kledzik at apple.com> wrote:
>
> On Feb 5, 2014, at 11:56 AM, Simon Atanasyan <simon at atanasyan.com> wrote:
>
>> I have read ELF specification once again. There is no any explicit
>> references to absolute symbols with no name. The only real case when I
>> see such symbol is a local absolute symbol with "STT_FILE" type. The
>> name of "STT_FILE" symbol is a name of the source file associated with
>> the object file and the "STT_FILE" symbol precedes the other STB_LOCAL
>> symbols from this object file. So it is just a "marker" symbol.
>>
>> If think it's enough to do not call buildDuplicateNameMap() if the
>> absolute atom has no name. I suggest to fix that in the code and write
>> a test covers this case.
> Sounds good.

Thanks for the discussion.
The fix committed at r200911.

-- 
Simon




More information about the llvm-dev mailing list