[LLVMdev] Please change the comment of 'insert' member function of SmallPtrSetImpl

JinGu Kang jingu at codeplay.com
Thu Dec 18 07:20:09 PST 2014


Hi all,

I have a compilation failure with 'insert' member function of 
SmallPtrSetImpl class because the return value is changed from r222334. 
But the comment of the function is same with before as follows:

   /// insert - This returns true if the pointer was new to the set, 
false if it
   /// was already in the set.
   std::pair<iterator, bool> insert(PtrType Ptr) {
     auto p = insert_imp(PtrTraits::getAsVoidPointer(Ptr));
     return std::make_pair(iterator(p.first, CurArray + CurArraySize), 
p.second);
   }

If the comment is changed, please change it.

Thanks,
JinGu Kang





More information about the llvm-dev mailing list