[LLVMdev] llvm-objdump
Sean Silva
chisophugis at gmail.com
Wed Aug 27 14:28:32 PDT 2014
On Wed, Aug 27, 2014 at 9:14 AM, Rafael EspĂndola <
rafael.espindola at gmail.com> wrote:
> > 2. Rip out the YAMLCFG stuff (including the corresponding library code)
> > since it seems totally borked.
>
> Is the attached patch OK? :-)
>
>
It appears that the YAML is just the skin of a lot of the MCAnalysis stuff
which looks dead. E.g. r182628, which adds the apparently unused -cfg
option for llvm-objdump. I think your patch leaves this MCAnalysis stuff
even more dead :-)
There's a whole string of commits for the MC CFG stuff that seemed to have
gotten dumped into trunk with no tests, and the post-review "tests?"
feedback on every one of the commits appears to have been mostly ignored.
It is probably worth ripping it all out at once.
-- Sean Silva
>
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140827/2feb10e2/attachment.html>
More information about the llvm-dev
mailing list