[LLVMdev] sys::path::system_temp_directory vs. sys::fs::createTemporaryFile

[Jordan Rose]

Okay, confirmed that this is reasonable on OS X. If we're okay with not having an env var for the cache dir, I'd say go ahead. Thanks, Rafael!

Jordan


On Aug 25, 2014, at 12:25 , Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> Ping2.
> 
> Rebased patch attached.
> 
> On 19 August 2014 12:08, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> ping. Rebased version attached.
>> 
>> On 14 August 2014 12:47, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>>> Well, that changes behavior on Linux; previously it did honor TMPDIR when
>>>> looking for a cache directory. Is that okay? (The Windows version is also
>>>> honoring TEMP in this case.)
>>> 
>>> I *think* that is a bug fix.  I don't have those env variables set on
>>> my linux machine (fedora 20), but I don't remember seeing them
>>> pointing to anything but /tmp in the past and that is even in tmpfs
>>> these days.
>>> 
>>>> What are we using the cache dir for besides the module cache?
>>> 
>>> Only that. There is one call in lvm and 2 in clang-tools-extra, but
>>> they both pass true to erasedOnReboot.
>>> 
>>>> Jordan
>>> 
>>> Cheers,
>>> Rafael
> <t.patch>