[LLVMdev] Explicit template instantiations in libc++

[Justin Bogner]

Justin Bogner <mail at justinbogner.com> writes:
> Bob Wilson <bob.wilson at apple.com> writes:
>>> On Aug 12, 2014, at 2:17 PM, Justin Bogner <mail at justinbogner.com> wrote:
>>> I'd like to restore these instantiations. Any thoughts on how to handle
>>> things like pr17027 in a less heavy handed way?
>>
>> As far as I can tell, the issue in pr17027 was that we had a bug in
>> libc++ and the libc++ dylib on some versions of OS X shipped with that
>> bug. Disabling extern templates “fixed” that by causing the newer code
>> from the headers to be used instead of the older code in the dylib on
>> the system. The real solution here is to fix the bug in the dylib and
>> ship a newer version. There may still be a lag in the time it takes us
>> to release fixes in the dylib, but that is just the way it goes.
>
> Alright, given this and the obvious performance difference, I think I'll
> go ahead and revert r189610. I'll keep an eye out for any pr17027-like
> fallout and fix them up if they come up.

I've done this in r215740.