[LLVMdev] What is HexagonTargetMachine::addPassesForOptimizations for?

Matthew Curtis mcurtis at codeaurora.org
Wed Apr 30 12:00:29 PDT 2014


On 4/30/2014 9:01 AM, Krzysztof Parzyszek wrote:
> On 4/30/2014 8:45 AM, Rafael EspĂ­ndola wrote:
>> On 30 April 2014 00:52, Craig Topper <craig.topper at gmail.com> wrote:
>>> This function is marked virtual but doesn't override anything, 
>>> doesn't have
>>> any overrides, and has no in tree callers. Can it be removed?
>>
>> Given that it is dead, yes :-)
>>
>
> It used to be called from clang, from lib/CodeGen/BackendUtils.cpp, 
> function CreatePasses.  It doesn't seem to be the case anymore.  I'm 
> not familiar with that part of the code.
> +Matthew
>
> -Krzysztof
>

It is actually part of a patch that we do not intend to upstream. 
Unfortunately this part of the patch slipped through. IMO it is ok to 
remove.
+Pranav who is even more familiar with the code.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation




More information about the llvm-dev mailing list