[LLVMdev] [ARM64] use_iterator in ARM64AddressTypePromotion.cpp

[Weiming Zhao]

Hi,

 

In ARM64AddressTypePromotion::propagateSignExtension(Instructions
&SExtInsts) {




while (!Inst->use_empty()) {

          Value::use_iterator UseIt = Inst->use_begin();     è should we use
“user_iterator”, “user_begin()” here ?

          Instruction *UseInst = dyn_cast<Instruction>(*UseIt);

          assert(UseInst && "Use of sext is not an Instruction!");

          UseInst->setOperand(UseIt->getOperandNo(), SExt);

        }

 

}

 

I don’t have a test case. I just saw it when I was browsing the code.

 

Thanks,

Weiming

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140416/ba308c35/attachment.html>