[LLVMdev] [lld][failing test] the reason of ifunc.test failing

[Rui Ueyama]

On Mon, Oct 7, 2013 at 11:51 AM, Shankar Easwaran
<shankare at codeaurora.org>wrote:

> Ping ?
>
> Do you think that we need to have an API in LinkingContext to return the
> next ordinal available, so that files created by passes can be assigned
> ordinals ?
>

That API may work, but I don't think you always want to assign the largest
file ordinal for a file created in a pass. If you want to assign the
smallest file ordinal, for example, then the API wouldn't work.


> Thanks
>
> Shankar Easwaran
>
>
> On 10/6/2013 11:07 PM, Shankar Easwaran wrote:
>
>> In addition I think the LayoutPass std::stable_sort be replaced with
>> std::sort as total ordering is guaranteed as each File would get an ordinal
>> and each atom would get an ordinal too, after the below problem is fixed.
>>
>> Thanks
>>
>> Shankar Easwaran
>>
>> On 10/6/2013 10:54 PM, Shankar Easwaran wrote:
>>
>>> Hi,
>>>
>>> It looks like the the ELFPassFile doesnot get an ordinal value assigned,
>>> as its added in a pass.
>>>
>>> Is there a way to assign a file ordinal for the files added by Passes ?
>>>
>>> Till that time, I am going to XFAIL the ifunc test.
>>>
>>> More tests should fail, and am not sure why they are not failing.
>>>
>>> Thanks
>>>
>>> Shankar Easwaran
>>>
>>>
>>
>>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
> ______________________________**_________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/llvmdev<http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131007/f67f11c8/attachment.html>