[LLVMdev] [PATCH] Prevent clang from throwing the diagnostics twice.

[Chad Rosier]

> Test cases?

Yes, please.

> Also, this seems a bit heavy-handed for a solution. Why is
> getLastArgIntValue being called twice in the first place?
>

I tend to agree with Aaron here.  However, I can't think of a better
solution.  Perhaps the issue is that getOptimizationLevel() is being
called multiple times?  The call happens in two different static functions
and I don't see a way to easily refactor the code.

 Chad

> ~Aaron
>
> On Fri, Nov 15, 2013 at 6:35 AM, Umesh Kalappa <umesh.kalappa0 at gmail.com>
> wrote:
>> Hi All,
>>
>> Clang pop up with the  "error: invalid integral value" diagnostics
>> twice
>> ,when you enable the optimization  through  -O with a  non-integer value
>> i.e -O<non integer>  as show below
>>
>> $ clang -Of -S test.c
>> error: invalid integral value 'f' in '-Of'
>> error: invalid integral value 'f' in '-Of'
>>
>>
>> Attached patch fix the issue as
>>
>> $ clang -Of -S test.c
>> error: invalid integral value 'f' in '-Of'
>>
>>
>> Clang version
>> clang version 3.4 (http://llvm.org/git/clang.git
>> 26297f57634994b4ae47a0774c372d6944265bb2) (http://llvm.org/git/llvm.git
>> 868e74bdce7a2c49d60e2ef56a077b0aa7f2ba08)
>>
>> Target: i386-pc-linux-gnu
>> Thread model: posix
>>
>> Builded successfully on trunk and is it ok to commit ??
>>
>>
>> Thanks
>> ~Umesh
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation