[LLVMdev] Any objections to my importing GoogleMock to go with GoogleTest in LLVM?

Chandler Carruth chandlerc at google.com
Tue Nov 12 22:21:17 PST 2013


Keep in mind that I am a maintainer for gmock so this would not change the
external project decencies of LLVM.
On Nov 12, 2013 9:16 PM, "Chris Lattner" <clattner at apple.com> wrote:

>
> On Nov 12, 2013, at 7:04 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
> > I have some concrete use cases in testing the pass manager where it will
> allow the tests of this API to be more thorough, less verbose, and easier
> to maintain. I'm not claiming to be the biggest fan of some features in
> GoogleMock, but on the whole, I think it's better than the alternative and
> will allow more careful testing of C++ APIs where the interesting part is
> the API itself.
>
> Personally, I rather not do this, without very clear and compelling
> reasons.
>
> I understand that this could be very useful for your bringup (and so could
> be very useful locally), but once the passmanager is the default, it will
> get lost of in-tree testing by just about everything in the compiler.
>
> I'm not really excited about dragging another out of tree project in
> unless there is a compelling reason to do so.
>
> -Chris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131112/5ff04739/attachment.html>


More information about the llvm-dev mailing list