[LLVMdev] [cfe-dev] Goal for 3.5: Library-friendly headers

[Chris Lattner]

On Nov 11, 2013, at 9:56 AM, Alp Toker <alp at nuanti.com> wrote:
> Done :-)
> 
> The patchset is 532K so I've put it online:
> 
>   http://www.nuanti.com/tmp/llvm-api-stability/
> 
> The bulk edits are split out and noted. They were refactored with an internal tool, so it's not a big hassle to keep this up to date until 3.4 is out the door.
> 
> A handful of fixes were needed to add support for Release+Assert builds and these are also separate commits.

Whoa whoa whoa.  Why are you introducing an llvm_assert() macro?  The use of assert in header files is not a problem for "libraries", it is things like:

#ifndef NDEBUG
  int SomeNewVariable;
#endif

in a class.

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131111/43c0963c/attachment.html>