[LLVMdev] Help with subtarget features and context-dependent asm parsers

[Richard Sandiford]

I'm trying to add some instructions that are only available on certain
processors.  These instructions use context-dependent parsers.  Everything
works fine for the valid cases, but if you try to use an instruction on
processors that don't support it, the asm parser says:

/tmp/foo.s:1:2: error: invalid operands for instruction
        sllk    %r2,%r3,1
                ^
rather than:

/tmp/foo.s:1:2: error: instruction requires: distinct-ops
        sllk    %r2,%r3,1
        ^
This is because MatchOperandParserImpl() skips custom parsers if the
subtarget feature isn't enabled, so the instruction is parsed using
the default operand parser instead.  Then MatchInstructionImpl() only
returns Match_MissingFeature if an otherwise good match is found,
which in my case requires the custom parser to be used.

ARM seems to rely on the current MatchOperandParserImpl() behaviour,
so I'm not going to suggest changing it unconditionally.  But on SystemZ
there aren't any cases where the choice of parse routine depends on the
enabled features.  It'd be better just to parse in the same way
regardless and check for errors at the end.

The patch below does that by adding an optional argument to
MatchOperandParserImpl().  It seems really ugly though.  Does anyone have
any better suggestions?

Thanks,
Richard


-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-features.diff
Type: text/x-patch
Size: 1704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130717/2d51d97c/attachment.bin>