[LLVMdev] [cfe-dev] llvm (hence Clang) not compiling with Visual Studio 2008

[Benoit Perrot]

Hello Ahmed,

On Fri, Jul 5, 2013 at 1:43 AM, Ahmed Bougacha <ahmed.bougacha at gmail.com>wrote:

> On Thu, Jul 4, 2013 at 12:48 AM, Benoit Perrot <
> benoit.noe.perrot at gmail.com> wrote:
>
>>
>>
> I have just updated my svn copy of the llvm/clang repositories after quite
>> a long time of inactivity, and found it not compiling on Windows with
>> Visual Studio 2008.
>> [...]
>> Solutions here:
>>
>> 1. consider that the implementation if effectively wrong, and modify the
>> documentation at http://llvm.org/docs/GettingStartedVS.html, requiring
>> Visual Studio 2010, i.e. replacing:
>> 2. investigate whether there exists a way to disable the aforementioned
>> check;
>> 3. modify the code in MCModule.cpp to cope with the implementation of
>> "lower_bound" in VS 2008.
>>
>> Personally I just went for (1), i.e. switching to Visual Studio 2010, as
>> it was the most straightforward.
>>
>
> (3) Fixed in r185676.
>
> Requiring VS 2010 for a minor problem like this (even though there are
> more like it) isn’t warranted I think.
>

Great!


> Doing so, I also had to add "#include <string>" to the file
>> "lib/CodeGen/CGBlocks.cpp" so that llvm/clang can compile with said
>> compiler, because of some obscure external template usage.
>>
>
> <string> is already included, at least by StringRef.h, so I’m curious:
> what is this obscure thing that needs including it again?
>
>
My build was in an intermediate invalid state.
Reverting said modification, cleaning completely then building again just
worked fine. Sorry for the false alarm.


Thanks!
-- 
Benoit PERROT
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130705/9d815fb3/attachment.html>