[LLVMdev] [llvm-commits] [llvm] r172534 - /llvm/trunk/test/Transforms/LoopStrengthReduce/post-inc-icmpzero.ll

[Chandler Carruth]

On Mon, Jan 21, 2013 at 11:49 AM, Andrew Trick <atrick at apple.com> wrote:

> Moving to llvmdev...
>
> On Jan 21, 2013, at 11:37 AM, Nadav Rotem <nrotem at apple.com> wrote:
>
> > Hi Manish,
> >
> > Thank you for looking at this. Recently opt started using the "-mtriple"
> command line flag to initialize the TargetMachine for IR-level
> transformations that use it. Currently only the following passes are using
> this feature: LSR, LowerSwitch, BBVectorizer and LoopVectorizer. If you
> look at the tests in LoopVectorize you will see that the target-dependent
> tests are in target-dependent directories.
>
> The tests in the platform directories are fine. The question is what to do
> about all the tests in target-independent directories that have "target
> triple" in the bitcode. These tests don't use -mtriple. Instead, their
> behavior changes in subtle ways depending on which targets are built. It's
> certainly a confusing situation.
>

My proposed resolution:
- If the tests are target independent, delete the triple.
- If they aren't, sink them to a target-specific subdirectory so they're
skipped in the absence of the target being built.
- Make a triple an error if there is not support for that target.

-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130121/0ce1e0bb/attachment.html>