[LLVMdev] [llvm-commits] [PATCH] A "very verbose" mode for FileCheck

[Dmitri Gribenko]

On Thu, Jan 17, 2013 at 7:51 PM, Sean Silva <silvas at purdue.edu> wrote:
> On Thu, Jan 17, 2013 at 8:36 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> We have to options:
>> (a) replace 'FileCheck' with '%FileCheck' in all tests, and teach
>> 'lit' to replace '%FileCheck' with 'FileCheck --dump-input-on-error';
>>
>> (b) teach 'lit' to replace a plain 'FileCheck'.
>>
>> The first approach seems cleaner to developers who read and write
>> tests (it suggests that they are invoking some "macro" -- but does
>> that matter?)  The second approach is much easier to implement since
>> tests will be unchanged.
>
> IMO the biggest issue with (a) is that developers will continue to use
> `FileCheck` instead of `%FileCheck`. So IMO (a) should only be
> implemented if simultaneously there is a change that makes just plain
> `FileCheck` an error.

I think that within a month this knowledge will be propagated to all developers.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/