[LLVMdev] [PATCH] A "very verbose" mode for FileCheck

[Chris Lattner]

On Jan 16, 2013, at 1:19 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> I agree that a command line option would be better.  But in that case
>> all tests should be updated.  It is not an issue for me -- it is
>> mostly mechanical.  So should I change tests to use %FileCheck?
> 
> Here's a third attempt.

Thanks in advance for driving this forward.  I'm sorry that such a simple thing is so complicated.

> The new behavior is as follows:
> 
> 1. In case of errors we always dump output to a temporary file and print
> 
> Saving input file "<stdin>" to "/tmp/filecheck.txt-Jno73y"

This doesn't make sense to me.  It's really common in a normal development scenario to do something, test and have stuff fail.  It doesn't make sense to dump things into /tmp in this case.

> 2. If --dump-input-on-error option is passed, FileCheck will also dump
> input to stderr.

This is fine.

> 3. If FILECHECK_DUMP_INPUT_ON_ERROR env var is set, lit will replace
> "%FileCheck" with "FileCheck --dump-input-on-error".

Sounds good for lit.

> I will fix all tests in LLVM and Clang if we decide this is the way to go.

What tests need to be fixed?  FileCheck -> %FileCheck?  You should check with Daniel, but would it make sense to have lit just "know" FileCheck?

-Chris