[LLVMdev] GCMetadataPrinter::finishAssembly not executed?

Yiannis Tsiouris gtsiour at softlab.ntua.gr
Wed Feb 27 08:05:13 PST 2013


Hi Dmitry,

On 02/27/2013 05:53 PM, Dmitry Babokin wrote:
> -    /// clear - Resets the pass. The metadata deleter pass calls this.
> +    /// clear - Resets the pass. The metadata printer pass calls this.
>
> I would propose different text here:
> /// clear - Resets the pass. Any pass, which uses GCModuleInfo(), 
> should call it in doFinalization().
>
> Does it make sense?
Yeap, totally! :-)

Thanks! Re-attaching for conveniency.

yiannis

-- 
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: http://www.softlab.ntua.gr/~gtsiour

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcinfodeleter-cleanup-v2.patch
Type: text/x-patch
Size: 1572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130227/6d80a525/attachment.bin>


More information about the llvm-dev mailing list