[LLVMdev] [cfe-dev] Phabricator email

[Manuel Klimek]

On Wed, Dec 11, 2013 at 6:49 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 11/12/2013 17:48, Renato Golin wrote:
>
>> On 11 December 2013 17:35, Alp Toker <alp at nuanti.com> wrote:
>>
>>> I noticed a few contributors have been landing patches without
>>> responding to
>>> my review comments.
>>>
>> Oh, that happened to me too, but it turns out you have to press the
>> "clowncopterize" after making comments inlilne, or Phabricator won't
>> publish them. You can see them, we can't.
>>
>
> Ah, don't think my email client has that feature ;-)
>

Yep, that's why we put "Note that as e-mail is the system of reference for
code reviews" into the docs - everybody should also follow the mails, and
reply to comments there as necessary... (if they don't, asking them nicely
to do so in the future will hopefully fix that problem).

Cheers,
/Manuel


>
> Alp.
>
>
>
>> cheers,
>> --renato
>>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131211/07e39e32/attachment.html>