[LLVMdev] make check rebuilds the project?

Eric Christopher echristo at gmail.com
Wed Apr 17 10:33:05 PDT 2013


On Wed, Apr 17, 2013 at 10:23 AM, Krzysztof Parzyszek
<kparzysz at codeaurora.org> wrote:
> On 4/17/2013 12:15 PM, Eric Christopher wrote:
>>
>>
>> Give a compelling argument and I might :)
>
>
> The cost is the extra time spent verifying that the binaries are fresh.  In
> my experience it has never happened that I ran "make check" on a wrong set
> of binaries.  On the other hand, it does happen that I run "make check"
> repeatedly, when working on a testcase (or a set of testcases), or when I
> fixed something that previously caused some testcases to be XFAILed.
>

The extra cost is pretty trivial and you can run individual test cases
by using lit explicitly. We've had annoying bot failures because
someone ran "make check" but it didn't rebuild the targets that check
depends upon. On my laptop it's a total of 4 seconds to get to
check... you probably would save more time by running lit explicitly
on a testcase you're changing :)

-eric



More information about the llvm-dev mailing list