[LLVMdev] R_ARM_ABS32 disassembly with integrated-as

[Greg Fitzgerald]

Nevermind, I see it now.  DataRegionEnd() is called after the data
region, but that's not necessarily the right spot to start the next
code region.  We need to EmitAlignment(1) first and then emit the
mapping symbols.

-Greg


On Sun, Oct 28, 2012 at 5:35 PM, Greg Fitzgerald <garious at gmail.com> wrote:
> I ran into a bug in this patch.  The mapping symbol produced is
> aligned and it should not be.  Is there a way to configure the
> MCSymbolRefExpr such that the emitted symbol is unaligned?
> Alternatively, should the ARM/Thumb code be realigned after a
> data-in-code section?  I notice that GCC leaves it unaligned.
>
> Thanks,
> Greg
>
>
> On Wed, Oct 17, 2012 at 2:32 PM, Renato Golin <rengolin at systemcall.org> wrote:
>>
>> On 17 October 2012 22:23, Greg Fitzgerald <garious at gmail.com> wrote:
>> > I had to move MCELF.h to "include/llvm/MC" and added a
>> > MCELFStreamer.h to the same directory.  That okay to do?
>>
>> This is not a trivial question, and I'll let others chip in.
>>
>> Superficially, you'd think so and it might make sense in the long run,
>> but you have to consider why it wasn't there in the first place.
>>
>> It may be that it didn't need to (in which case, it's ok to move), or
>> it may be that the design of MC needed those headers to be more
>> private (in which case it might not be ok).
>>
>> Certainly, Tim or Jim know better than I do.
>>
>> --
>> cheers,
>> --renato
>>
>> http://systemcall.org/