[LLVMdev] dragonegg polly support broken?

[Jack Howarth]

On Sun, Oct 21, 2012 at 11:58:43AM -0700, Tobias Grosser wrote:
...
> Does attached patch work for you?
>
> Tobi
>

Tobi,
  Yes, with this patch current llvm/polly svn builds and runs 'make polly-test'
without issues in finding LLVMPolly.so. Thanks for fixing this so quickly.
  Do you have any comments on failing tests we are seeing on x86_64-apple-darwin11?

Failing Tests (5):
    Polly :: CodeGen/do_pluto_matmult.ll
    Polly :: CodeGen/single_do_loop_int_max_iterations.ll
    Polly :: CodeGen/single_do_loop_scev_replace.ll
    Polly :: IslCodeGen/single_loop_param_less_equal.ll
    Polly :: IslCodeGen/single_loop_param_less_than.ll

Are these darwin-specific or due to the fact that I am using isl 0.10 and
cloog 0.17 rather than their the upstream development svn? Let me know if
any of those merit a bugzilla of their own.
          Jack

> >From 8621fa79089a9769a84ccfb3f79c927ea64fab81 Mon Sep 17 00:00:00 2001
> From: Tobias Grosser <tobias at grosser.es>
> Date: Sun, 21 Oct 2012 11:54:04 -0700
> Subject: [PATCH] cmake: Use suffix for shared modules instead of the one for
>  shared libraries
> 
> On Linux there is no difference between shared modules and shared libaries, both
> are '.so' files. However, on darwin only shared modules are '.so' files. Shared
> libraries have the '.dynlib' suffix.
> 
> Fix test cases on darwin by expecting a shared module suffix for Polly instead
> of a shared library suffix.
> ---
>  test/CMakeLists.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> index c433ebe..24ccab0 100644
> --- a/test/CMakeLists.txt
> +++ b/test/CMakeLists.txt
> @@ -11,7 +11,7 @@ set(POLLY_TEST_DIRECTORIES
>  
>  set(POLLY_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/..")
>  set(POLLY_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/..")
> -set(LLVM_SHLIBEXT "${CMAKE_SHARED_LIBRARY_SUFFIX}")
> +set(LLVM_SHLIBEXT "${CMAKE_SHARED_MODULE_SUFFIX}")
>  
>  if (NOT DEFINED LLVM_MAIN_SRC_DIR)
>    # We are building polly out of tree, adjust the settings.
> -- 
> 1.7.9.5
>