[LLVMdev] [PATCH / PROPOSAL] bitcode encoding that is ~15% smaller for large bitcode files...

[Jan Voung]

On Sat, Oct 6, 2012 at 8:32 AM, Rafael Espíndola <rafael.espindola at gmail.com
> wrote:

>
> +static void EmitSignedInt64(SmallVectorImpl<uint64_t> &Vals, uint64_t V) {
>
> Please start function names with a lower case letter.
>
>
Done -- changed this function and most of the "pushValue" functions.  I
left PushValueAndType alone since that is an existing function and it
seemed like that would introduce other unrelated changes.


> +EnableOldStyleFunctions("enable-old-style-functions",
>
> Maybe something like use-abs-operands is a better name now that this
> is a global setting, no?
>

Yes that would be more descriptive.  Changed in new patch.


>
> > - Jan
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121008/0599d7ba/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: relative_ids.patch5
Type: application/octet-stream
Size: 38577 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121008/0599d7ba/attachment.obj>