[LLVMdev] [llvm-commits] Improve Covered Default Switch detection (keep try)

Joe Abbey jabbey at arxan.com
Sun Nov 25 18:04:00 PST 2012


r168577

Cheers,

Joe

On Nov 25, 2012, at 9:01 PM, David Blaikie <dblaikie at gmail.com> wrote:

> As per discussion on IRC this looks good (enough) to me for commit.
> Hopefully if others have better/other ideas about how to do this with
> CMake they can provide it in post commit review.
> 
> Thanks for the fix,
> - David
> 
> On Sun, Nov 25, 2012 at 5:16 PM, Joe Abbey <jabbey at arxan.com> wrote:
>> Here's a reduced version of the previous patch.
>> 
>> Keeping it dead simple.
>> 
>> jabbeymbp:build jabbey$ cmake ..
>> 
>> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
>> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success
>> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
>> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Failed
>> 
>> jabbeymbp:build jabbey$ CC=/usr/bin/clang cmake ..
>> 
>> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
>> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success
>> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
>> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success
>> 
>> Ok to commit?
>> 
>> Joe
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 





More information about the llvm-dev mailing list