[LLVMdev] [llvm-commits] Improved Covered Default Switch detection
Joe Abbey
joe.abbey at gmail.com
Sun Nov 25 17:12:48 PST 2012
>> It's too late here, sorry, but your patch seems plain correct.
>>
>> The unrelated set(... -> list(APPEND changes shouldn't be mixed with the
>> fix proper, IMO. Same for the cmake_minimum_required command. LLVM
>> already requires cmake version 2.8 on the top CMakeLists.txt.
>
> BTW, you want
>
> set(FOO "${FOO} something")
>
> instead of
>
> list(APPEND FOO something)
>
> because those variables are strings, not lists. Using the `list' version
> may cause unwanted semicolons in the command line.
Thanks for the extra info. I understood that list append was "faster", and wasn't aware of spurious semicolons.
I'll start a new thread with the reduced patch.
:)
Joe
More information about the llvm-dev
mailing list