[LLVMdev] RFC: Code Ownership

Michael Spencer bigcheesegs at gmail.com
Mon Nov 12 12:19:29 PST 2012


On Mon, Nov 12, 2012 at 10:40 AM, David Blaikie <dblaikie at gmail.com> wrote:
> Phabricator provides a way to set up notifications for changes to
> certain parts of the codebase & you can then "accept" those changes
> which is probably the right way to do this, but I haven't tried the
> workflow myself.
>
> - David

I currently use this and find it works quite well. The only issues
with it that I've found are that everyone has to be registered and
have the same username as svn for "raise concern" to alert them. The
other is that you still get an audit even if the patch was approved
pre-commit.

The first issue is already being worked on. The second isn't really a
generally solvable problem unless you include the phabricator
Differential number in the commit message, as quite a few reviews end
with "change x and commit".

- Michael Spencer



More information about the llvm-dev mailing list