[LLVMdev] [PATCH] Build llvm-config on Windows/MSVC if sed is present

[Óscar Fuentes]

Justin Holewinski <jholewinski at nvidia.com> writes:

> The attached patch modifies the CMake/LLVMBuild scripts to build
> llvm-config on Windows if sed is found on the user's PATH.  It also
> teaches LLVMBuild about MSVC library naming so llvm-config will
> produce the proper lists of library names.
>
> Any comments?  Okay to commit?

The presence of sed does not mean that it is usable. Think on a
Cygwinized `sed' while building for MSVC. I'm not sure that on that case
it can handle the pathnames as issued by cmake.

IMO the right fix is to get rid of sed altogether. Cmake has
text-manipulation capabilities that should be enough for the job, IIRC.

[snip]