[LLVMdev] [PATCH] Apply Thumb2 ROR optimization only when Thumb2 is supported

[Fischer, Matt]

I've been playing around with using LLVM on one of our projects, which runs on an arm1176jzf-s processor.  When compiling for Thumb, a couple of the generated assembly files end up with a 'ror.w' instruction, which is a Thumb2 instruction.  Since arm1176jzf-s doesn't support Thumb2, the assembler then turns around and barfs on it.

I don't have any experience with this codebase, but after looking around for a while, I think I found the culprit--there was a change back in #130502 which added a peephole optimization to generate that instruction, but the pattern was not made conditional on being in Thumb2 mode.  If that's correct, then I believe the attached patch will fix it (at the very least, it made my specific error go away).  Is this the right fix?

Thanks,
Matt

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient. If you are not the intended recipient, please be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please contact the sender and delete all copies.

Thank you for your cooperation.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Apply-Thumb2-ROR-optimization-only-when-Thumb2-is-su.patch
Type: application/octet-stream
Size: 1024 bytes
Desc: 0001-Apply-Thumb2-ROR-optimization-only-when-Thumb2-is-su.patch
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120629/fbb5b819/attachment.obj>