[LLVMdev] [PATCH] Moving DebugInfo module to VMCore

Eric Christopher echristo at apple.com
Wed Jun 27 16:20:54 PDT 2012


On Jun 27, 2012, at 4:08 PM, Bill Wendling <wendling at apple.com> wrote:

> Hi all,
> 
> This patch, though large, simply moves lib/Analysis/DebugInfo.cpp to lib/VMCore/DebugInfo.cpp and include/llvm/Analysis/DebugInfo.h to include/llvm/DebugInfo.h.
> 
> Why? Because this module has nothing to do with analysis. It simply defines an interface to the debug info MDNodes. In fact, the lib/VMCore/AsmWriter.cpp file performs a layering violation, because it calculates the DWARF tag from this debug info, which is more appropriately calculated via the debug info module. It could eventually allow us to use the debug info module's comment printer to generate fuller comments in the .ll file. 
> 
> Okay to commit?
> 
> -bw
> 
> <clang-debuginfo.patch><debuginfo.patch>

Sure, I'm ok with that.

-eric



More information about the llvm-dev mailing list