[LLVMdev] [llvm-commits] [Patch, RFC] Re: Adding support for explicitly specified TLS models (PR9788)

[Rafael Espíndola]

> Attaching a new patch that has the behaviour we discussed.
>
> The "globaldynamic" and default values have been merged, and LLVM will
> start off with the user-specified model, but choose a more specific
> one if possible.
>
> Please review.

Awesome, thanks!
I will try to do a more complete review tonight or tomorrow. For now,
just two quick observations

*) This breaks the clang build, it would be nice to for the first
commit to keep the old API. It can be removed as soon as clang is
updated.
*) Please name the most general model GeneralDynamicTLSMode. Elf's
default visibility being called 'default' is already confusing enough
:-)

I was not sure how hard the first item would be, so I just gave it a
try. The resulting patch is attached.

> Thanks,
> Hans

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 38564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120620/61fd4a44/attachment.obj>