[LLVMdev] RFC: How can AddressSanitizer, ThreadSanitizer, and similar runtime libraries leverage shared library code?

[Dmitry Vyukov]

On Wed, Jul 11, 2012 at 12:59 PM, Alexey Samsonov <samsonov at google.com>wrote:

> Reviving the discussion.
>
> The cool cmake-build of compiler-rt is not completely functional, but
> allows sanitizer runtimes to reuse LLVM code with almost no dirty hacks.
> Suppose I want to run call functions from LLVM libs (currently:
> LLVMDebugInfo, LLVMSupport) from sanitizer runtime.
>
> 1) I can simply include LLVM headers in sanitizer runtime, and it compiles
> and builds static asan runtime perfectly (wow).
> 2) Now building and running ASan unittests is simple - you just have to
> add a couple of lines to CMakeLists.
>         target_link_libraries(${testname} LLVMSupport)
>         target_link_libraries(${testname} LLVMDebugInfo)
> 3) Now to make "-faddress-sanitizier" work you have to patch a Clang
> driver, so that it links not only ASan runtime, but also two
>   of the mentioned static LLVM libraries (and add -lstdc++ flag as well).
>
> But, as Dmitry mentioned, we may run into troubles as we may mix
> instrumented and un-instrumented
> versions of the same functions (identical methods from std::vector<> will
> be instrumented in user-code and not instrumented in LLVM code).
> This problem seem to be more important for TSan (it takes some effort to
> check that, as TSan is not currently buildable with LLVM, I think
> I can try to fix this soon).
>
> Chandler, is this exactly the problem you're trying to solve with your
> linker tool?
> Dmitry, do I understand correctly that it's really better to get rid of
> unnecessary (if not all) STL in LLVM methods we plan to use anyway?
>


Well, my idea was to use only DebugInfo from llvm and remove all STL from
it.
Chandler's magic tool may also do, but obviously it's something not that
trivial that just having the source code in the form we need. But on the
other hand, if we are going to use something else from llvm, then we will
need to remove STL from there as well, so it does not look scalable
(however, as it is seen now we don't need anything else from llvm).
I am OK with any option if it is implemented quickly and works w/o problems.



>
> On Thu, Jun 21, 2012 at 2:06 PM, Dmitry Vyukov <dvyukov at google.com> wrote:
>
>> On Thu, Jun 21, 2012 at 1:44 PM, Chandler Carruth <chandlerc at google.com>wrote:
>>
>>>   Can we alter the build system so that when building a run-time
>>>>>>>>>> library it modifies all .cpp files like this:
>>>>>>>>>>    namespace FOO {
>>>>>>>>>>    <file body>
>>>>>>>>>>    }
>>>>>>>>>> This will give us essentially the same thing, but w/o system
>>>>>>>>>> dependent object file hackery.
>>>>>>>>>> Maybe we can add a Clang flag to add such a namespace for us?
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I think this is essentially what Dmitry was talking about w/ past
>>>>>>>>> STLport experience. It has lots of limitations:
>>>>>>>>>
>>>>>>>>
>>>>>>>> Patching object files still sounds much scarier and harder to port.
>>>>>>>> I'd prefer to find a solution that involves only source files and
>>>>>>>> maybe clang.
>>>>>>>> Pondering...
>>>>>>>>
>>>>>>>>
>>>>>>>>> - You can't use the normal system standard library
>>>>>>>>>
>>>>>>>> - You have to build the standard library from source
>>>>>>>>> - You can't wrap certain parts of it (operator new, delete, a few
>>>>>>>>> other things)
>>>>>>>>> - You can't re-use any C libraries (zlib for example)
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> Perhaps you are solving a broader problem. But as for asan/tsan, we
>>>>>>> currently need only symbolizer, it's separable from everything else, and
>>>>>>> can be made to not use STL.
>>>>>>>
>>>>>>
>>>>>> If you want to share LLVM code for the object and dwarf reading, I do
>>>>>> not believe this to be true at all.
>>>>>>
>>>>>
>>>>> I've already removed code for the object reading for exactly that
>>>>> reason, so now it's just dwarf parsing :) There are some CTL containers
>>>>> involved, but I think they can be replaced.
>>>>>
>>>>
>>>> Agree here. I hope to modify/extend this code soon anyway.
>>>>
>>>
>>> Folks, this is not the path to sharing code. This is the path to forking
>>> code.
>>>
>>> Let's go back to the very premise: I think it is highly desirable to be
>>> capable of building runtimes such as ASan and TSan and *share* code rather
>>> than forking it.
>>>
>>> I have reasons: I have seen the creation of at least three separate ELF
>>> and/or DWARF parsing libraries thus far. I have seen a long series of bugs
>>> found and fixed in them over the course of years, often the same bug, often
>>> with great expense in debugging to understand why. I don't want us to keep
>>> paying this cost. I don't think these pieces of code are likely to be alone
>>> in this.
>>>
>>>
>>> Now, perhaps I am wrong, and it is not worth it. Thus far, I don't hear
>>> any convincing arguments to that effect, but I'm very willing to believe
>>> I'm wrong as I don't work on one of these runtimes, and so don't have a
>>> direct appreciation for all of the costs involved.
>>>
>>> But let's be extremely clear on what you are suggesting: you are
>>> specifically doing away with the very idea of sharing code with the rest of
>>> the LLVM project, and instead deciding to fork and write custom code in the
>>> runtime for all functionality.
>>>
>>
>>
>> No, we do not want to fork any code.
>> My ObjectFile replacement is 20 lines of code including error handling
>> (open file, get size, mmap).
>>
>>
>
>
> --
> Alexey Samsonov, MSK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120711/17edab5d/attachment.html>