[LLVMdev] [llvm-commits] [PATCH][Compiler-rt] Windows implementation of mmap functionality in clear_cache_test and enable_execute_stack_test

Anton Korobeynikov anton at korobeynikov.info
Sat Jan 7 14:14:41 PST 2012


Hi Ruben,

> I see I missed some curly braces. I also modified spacing a tiny bit.
Doesn't seem so. E.g. you have:

+    if ( !VirtualQuery(addr, &b, sizeof(b)) )
+        exit(1);
+    if( !VirtualProtect(b.BaseAddress, b.RegionSize,
PAGE_EXECUTE_READWRITE, &b.Protect) )
Add space after "if". Do not put spaces after "(" and before ")". Same
for other places in the file.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-dev mailing list