[LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release

[Tom Stellard]

Hi Chris,

Ben and Dmitri have completed coding style reviews for the R600 backend,
and I have made all the requested changes.  What else needs to be done
before we can commit this backend to the main tree?

Thanks,
Tom

On Thu, Nov 29, 2012 at 05:09:57PM +0100, Benjamin Kramer wrote:
> 
> 
> $ grep -r '^[ ]*{$'
> 
> Otherwise I don't see anything else that needs fixing offhand.
> 
> > I've also included in that directory the 6 patches I wrote to implement
> > these changes, to make it easier to see what is different.  If you see
> > anything I left out, let me know.
> > 
> >> Overall I think this should go in as soon as possible. It has been around for a while and you have been actively maintaining it over the whole timespan since it was first proposed for inclusion. I'm afraid it's too late for 3.2, but we're now early in the 3.3 cycle and it would be really nice to have a stable R600 backend in 3.3.
> >> 
> > 
> > Assuming I caught all the coding style mistakes you pointed out, what
> > else needs to be done to be able to commit this code?
> 
> IMO this can go in now, but you'll need approval from Chris.
> 
> - Ben