[LLVMdev] Instrumentation passes and -O0 optimization level

Alexander Potapenko glider at google.com
Tue Nov 29 08:56:34 PST 2011


>
>> + EP_EnabledOnOptLevel0
>
> I'd rename this as EP_AlwaysEnabled
>
Renamed, see the attachment.

But note that one needs to add his pass at two extension points: at O0
and wherever else he wanted to add it.
Won't such a name confuse the user?
E.g. he may think that just adding a pass as "EP_AlwaysEnabled" should
be enough to have it at any optimization level.

PS. Should we move the discussion to cfe-commits or it's ok to
continue the review process here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: text/x-patch
Size: 1804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20111129/246caba6/attachment.bin>


More information about the llvm-dev mailing list