[LLVMdev] [Segmented Stacks] Week 1

Rafael Avila de Espindola rafael.espindola at gmail.com
Tue May 31 13:55:07 PDT 2011


On 11-05-30 07:20 AM, Sanjoy Das wrote:
> Hi!
>
> I've attached my first week of work as a patchset for review. This is
> also available on Github [1].
>
> By next Monday I intend to (more or less) finish up the preliminary
> parts concerning the codegen; and start working on the runtime (so that
> I can do a basic sanity check).

Thanks!. Some quick notes

*) Maybe you could add the description you used for the GSoC to the 
segmented-stacks document too? Maybe at the end and under a "not yet 
implemented" section, but having it all in one place is probably useful.

*) You use "stack block" in some places and stacklets in others.

*) You mention that variable sized alloca's are handled by using the 
heap. This is an interesting idea, but you have to be careful to avoid 
leaks if exceptions are enabled.

*) If I remember correctly, you wanted to fold the red zone in the "do I 
need more stack" check, but I seed that you have a 
!EnableSegmentedStacks in the Red Zone check. Have you decided not to do it?

*) You intend for the runtime to be compatible with the gcc one? Their 
stack allocating function is called __morestack...

> [1] https://github.com/sanjoy/llvm/tree/segmented-stacks
>

Cheers,
Rafael



More information about the llvm-dev mailing list