[LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly

Rafael Avila de Espindola rafael.espindola at gmail.com
Fri May 20 13:20:52 PDT 2011


> .ll ->  .s test added. As far as I can tell .ll ->  .s and .ll ->  .o go
> different paths, so I have both .ll->.s and .ll ->  .o in the test case
>
> The revised patches (with tests in .diff) are attached.
>
> patch-2-3.diff:
>    fixes target address tBL and tBLX and sets relocation type
>    of tBL/tBLX to R_ARM_THM_CALL (ARM ELF 4.7.1.6)
>
> patch-4.diff:
>    adds some attributes to attribute section when cpu is "xscale"
>    (this is what used in Android NDK, when architecture is ARMv5)


Done. Just two nits: A single ';' is sufficient to start a comment and 
it is easier to review patches if you attach them directly to the email.

> Thanks,
> // koan-sin tan

Thanks,
Rafael



More information about the llvm-dev mailing list