[LLVMdev] [MIPS] some type errors in the commentary of *.td file.

Liu proljc at gmail.com
Mon May 9 18:51:19 PDT 2011


On Tuesday, May 10, 2011, Eric Christopher <echristo at apple.com> wrote:
>
> On May 7, 2011, at 2:47 AM, Liu wrote:
>
>> On Sat, May 7, 2011 at 12:33 PM, Eric Christopher <echristo at apple.com> wrote:
>>>
>>> On May 5, 2011, at 11:26 PM, Liu wrote:
>>>
>>>>  some some type errors in the commentary of *.td file.
>>>> such as:
>>>> lib/Target/Mips/MipsInstrFormats.td
>>>> MipsRegisterInfo.td - Mips Register defs
>>>> it should be
>>>> MipsInstrFormats.td - Mips Instruction Formats
>>>>
>>>> lib/Target/Mips/MipsInstrInfo.td
>>>> MipsInstrInfo.td - Mips Register defs
>>>> it should be
>>>> MipsInstrInfo.td - Target Description for Mips Target
>>>>
>>>> and some thing I think it is wrong in lib/Target/Mips/MipsInstrFPU.td.
>>>>
>>>> Will the patch be OK?
>>>>
>>>> Best regards.
>>>>
>>>> --Liu
>>>> <Mips-td-comment-type-error.patch>
>>>
>>> Looks fine. Do you need someone to apply this for you?
>>>
>>> -eric
>>>
>>
>> Hi Eric
>>
>> I'm so glad someone apply this to me. Will you?
>> Thanks.
>
> Applied here:
>
> [yendi:Data/sources/llvm] echristo% svn ci lib/Target/Mips/
> Sending        lib/Target/Mips/MipsInstrFPU.td
> Sending        lib/Target/Mips/MipsInstrFormats.td
> Sending        lib/Target/Mips/MipsInstrInfo.td
> Transmitting file data ...
> Committed revision 131086.
>
> -eric
>

Hi Eric,

Thank you for review and apply, nice man.

Best wishes,

--Liu




More information about the llvm-dev mailing list