[LLVMdev] Typo in IsLegalToCallImmediateAddr?

David Meyer pdox at google.com
Fri Jul 1 14:13:07 PDT 2011


It seems that the || should be && here?

/// IsLegalToCallImmediateAddr - Return true if the subtarget allows calls
/// to immediate address.
bool X86Subtarget::IsLegalToCallImmediateAddr(const TargetMachine &TM) const {
  if (Is64Bit)
    return false;
  return isTargetELF() || TM.getRelocationModel() == Reloc::Static;
}

For example, if you are doing ELF PIC (i.e. for a shared library), it
is not valid to use a call immediate.

- David



More information about the llvm-dev mailing list