[LLVMdev] [PATCH] OpenCL support - update on keywords

[Villmow, Micah]

The problem is that we use the ordering private, global, constant and local, and this is the same ordering that is used on Apple as well. As we already have OpenCL binaries out in public, making the change is problematic as we want to keep backward compatibility at all costs. 

Thanks,
Micah

> -----Original Message-----
> From: Anton Lokhmotov [mailto:Anton.Lokhmotov at arm.com]
> Sent: Monday, February 21, 2011 1:45 AM
> To: Villmow, Micah; 'Peter Collingbourne'
> Cc: llvmdev at cs.uiuc.edu; cfe-dev at cs.uiuc.edu
> Subject: RE: [PATCH] OpenCL support - update on keywords
> 
> > > > > +enum OpenCLAddressSpace {
> > > > > +  OPENCL_PRIVATE = 0,
> > > > > +  OPENCL_GLOBAL = 1,
> > > > > +  OPENCL_LOCAL = 2,
> > > > > +  OPENCL_CONSTANT = 3
> > > > > +};
> 
> > -----Original Message-----
> > From: Villmow, Micah [mailto:Micah.Villmow at amd.com]
> >
> > Anton,
> >   Would there be any issue with switching the ordering of constant
> and
> > local?
> 
> Hi Micah,
> 
> We'd rather not do that.  First, this order follows the order of
> subsections
> in 6.5 of the OpenCL specification, with global described in 6.5.1,
> local in
> 6.5.2, constant in 6.5.3; private is described in 6.5.4 but it's also
> the
> default function-scope space which is 0.  Second, we use the same order
> in
> our (non-LLVM) GPU backend.
> 
> Best regards,
> Anton.
> 
> 
>