[LLVMdev] [cfe-dev] anchoring explicit template instantiations

[Jakob Stoklund Olesen]

On Dec 19, 2011, at 8:35 PM, Ted Kremenek <kremenek at apple.com> wrote:

> On Dec 19, 2011, at 5:40 PM, Chris Lattner wrote:
> 
>> On Dec 10, 2011, at 5:20 PM, David Blaikie wrote:
>>>>> Thanks Chris, committed as r145578. I don't suppose you'll mind some
>>>>> similar commits as I encounter them?
>>>> 
>>>> Yep, please feel free.
>>> 
>>> While you said this - given that I've now gone & fixed /every/
>>> violation of -Wweak-vtables across LLVM & Clang (apart from some llvm
>>> target tblgen problems - not sure how practical they are to fix. And
>>> gtest also fires this warning) I thought I should probably get at
>>> least a '*nod*' before I check this in.
>> 
>> Looks fine to me, please do.
> 
> Chris,
> 
> I really hate this change.  Is this really the only way to solve this problem?

I am skeptical too. David just added 17 translation units with the purpose of speeding up the build.

Did it work? Numbers, please.

/jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20111219/db835163/attachment.html>