[LLVMdev] Multiple one-line bugs in LLVM

Bill Wendling wendling at apple.com
Thu Aug 4 10:55:02 PDT 2011


On Aug 4, 2011, at 9:03 AM, Duncan Sands wrote:

>> 
>> lib/MC/MCParser/AsmLexer.cpp:149
>>   while (CurChar != '\n'&&  CurChar != '\n'&&  CurChar != EOF)
>> 
>> There are identical sub-expressions to the left and to the right of the '&&'
>> operator: CurChar != '\n'&&  CurChar != '\n'. The second expression should
>> probably be CurChar != '\n'?
> 
> Chris also added this code, hopefully he will comment.
> 
I think you mean that it should be CurChar != '\r', which seems more logical. :)

-bw




More information about the llvm-dev mailing list