[LLVMdev] LLVM test-suite support for dragonegg / Fortran

[Tobias Grosser]

On 11/12/2010 12:11 PM, Duncan Sands wrote:
> Hi Tobias,
>
>> I committed an extended version of that patch to llvm core and the
>> test suite.
>> Can you have a look, if it works for you.
>
> if I configure like this then the configure script thinks llvm-gcc is not
> dragonegg:
>
> configure --with-llvmgcc="gcc-4.5 -fplugin=path/dragonegg.so"
> --with-llvmgxx="g++-4.5 -fplugin=path/dragonegg.so"
>
> There are several reasons for this. First off, the test
> if test -x "$LLVMGCC" ; then
> fails because "g++-4.5 -fplugin=path/dragonegg.so" is indeed not an
> executable.
> This test is redundant, since you are about to execute the program on
> the next
> lines, which will fail anyway. Suppose this test is eliminated. It still
> fails
> because
>
> "$LLVMGCC" -fplugin-arg-dragonegg-emit-ir -S -o - conftest.c
>
> won't execute, because "$LLVMGCC" is not an executable. This can be
> cured by
> removing the quotation marks. This suggests the following patch, what do
> you
> think? I'm worried that this is the wrong approach. If it is the right
> approach, probably the testsuite configure files will need to be tweaked
> too.
>
> Ciao,
>
> Duncan.
Hi Duncan,

I have used the dragonegg installed by ubuntu. It uses a script 
installed as llvm-gcc, which just adds "-fplugin=path/dragonegg.so" to 
the arguments and than calls gcc.

I am not sure which is the best approach to support not just a binary, 
but a binary with arguments for LLVMGCC. I am a little bit worried that 
there may be more places that expect LLVMGCC to be a binary.

However, as I do not see any problems arising from this patch, I am fine 
with it. It is needed if we want dragonegg support for LLVMGCC without 
the use of a separate script.

I propose to wait a day to see, if anybody else can see a problem.

Cheers
Tobi