[LLVMdev] Win32 COFF Support

[Aaron Gray]

On 2 May 2010 00:59, Nathan Jeffords <blunted2night at gmail.com> wrote:

> Hi All,
>
> I have created a minimally functional Win32 COFF Exporter using the new MC
> framework. I made some minor changes to other libraries to allow me to plug
> it in without building it as part of the LLVM project. I wanted to share it
> but wasn't sure how to go about doing so, so I have attached the code to
> this message.
>
> Any feedback on would be appreciated.
>

Hi Nathan,

A couple of points :-

1) Your code seems incomplete, there is nothing envoking
'createWin32CoffStreamer()' in you patch.
2) You need to look at LLVM coding standards, i.e. maximum line length of 80
characters and tabs of 2. You need to look at the following document and
existing code. Usage of spaces is quite strict.

   http://llvm.org/docs/CodingStandards.html

I too have been working on a COFFWriter but with little success. Got a basic
COFFWriter working but have had problems with the MC framework in regards to
getting the right information to generate code properly.

It will be good if we can get something working first, so send me a proper
change set, read this :-

    http://llvm.org/docs/DeveloperPolicy.html

I generally use :-

    utils/mkpatch patchname

from the root svn directory with out the '.patch' to make patches. You need
to include any files from 'svn status' with question marks, by doing an 'svn
add filename'.

Thanks for submitting a patch, most patches are welcomed, but they may need
to be honed a bit.

Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100502/f52bd776/attachment.html>