[LLVMdev] [PATCH] Before/After IR Dumps
David Greene
dag at cray.com
Tue Mar 30 14:09:11 PDT 2010
On Tuesday 30 March 2010 15:20:09 Chris Lattner wrote:
> On Mar 30, 2010, at 12:27 PM, David Greene wrote:
> > On Monday 29 March 2010 13:20:37 Chris Lattner wrote:
> >>> How should we handle the llvm-gcc and clang changes?
> >>
> >> What changes are required?
> >
> > Attached. They are trivial.
>
> Why not just change the order of the arguments to createPrintModulePass,
> and make the string default to ""?
1. I wanted to be consistent with createPrintFunctionPass.
2. Default arguments are often evil. Maybe not in this case but I didn't want
to encourage their use. :)
That said, I'll go ahead and make this change to reduce the impact of this.
-Dave
More information about the llvm-dev
mailing list