[LLVMdev] patches for the LLVM cmake build system

[Óscar Fuentes]

Victor Zverovich <victor.zverovich at googlemail.com> writes:

> Hi llvm-dev,
>
> Attached are two patches for the LLVM cmake build system.
>
> The first one adds static runtimes (MT and MTd) to the list of runtimes for
> the MSVC build.

This seems not to be as easy as you put it. It was discussed here
recently:

From: José Fonseca
Subject: [PATCH]: MSVC build enhancements
Date: Sat, 6 Mar 2010 10:43:50 +0000

> The second one makes it possible to use llvm_config in external projects.
> In this patch I took the liberty of changing the format of LLVMLibDeps.cmake
> to define a single variable LLVM_LIB_DEPS instead of MSVC_LIB_DEPS_*.
>  LLVM_LIB_DEPS contains the list of libraries and dependencies in the
> following form:
>
> set ( LLVM_LIB_DEPS
>  * <lib-name> <dependency 1> ... <dependency n>
>  ...
>   )
>
> Here '*' is used as a delimiter to specify where each library dependency
> list starts
>
> This allows to get both the list of libraries and dependency information
> from one source. It is done in the explicit_map_components_to_libraries
> function which uses LLVM_LIB_DEPS to populate llvm_libs and MSVC_LIB_DEPS_*
> if they are not defined thus allowing external use.

Interesting idea. But this method does not take into account the case
where the user does not build all libraries (i.e. ignores some LLVM
targets). On this scenario your method will take into account all
libraries, including those not built. IMO it is really needed to know
which LLVM libraries were built before resolving dependencies for client
projects, as it actually does for resolving dependencies for the LLVM
tools. I pretend to incorporate this information on a cmake file that is
installed along the rest of LLVM.