[LLVMdev] Win32 COFF Support

[Chris Lattner]

On Jun 14, 2010, at 12:41 PM, Nathan Jeffords wrote:

> Michael,
> 
> I have not made any changes since I last posted a patch. If you would like to make the final updates, thats fine by me. I don't mind making the changes either, I can have them done this evening as well.
> 
> Chris,
> 
> As far as naming goes, PE/COFF used in Microsoft's document because they are describing both their version of COFF, and their Portable Execution format which is a slightly modified version of their COFF format. I don't think that PE belongs there since this code doesn't generate executables. I used the Win prefix to differentiate it from non Microsoft Windows versions of COFF.

Ok.

> For the debug macros, I personally like them because they reduce the impact debug code has on the "real" code. I find dbgout("message") simpler and more concise than DEBUG(dbgs() << "message") for the consumer of the debug API. The other macros are there to not have to reproduce the same pattern a repeatedly.

Are these intended to stay permanently or are they just for bring-up?  Your argument implies that we should pull them into a higher-level header file, but personally I think that explicitly using "dbgs() <<" makes it clearer what is happening.

-Chris